Skip to content

Conversation

@scott-the-programmer
Copy link
Owner

@scott-the-programmer scott-the-programmer commented Oct 11, 2024

Closes #170

This PR maps the wait property to VerifyComponents which should allow the provider to hold off until the predefined components are ready

Few things todo before merging

  • Validate whether the property uses any of the supported values
  • Map "all" or "true" to all possible values
  • Map "none" or "false" to an empty map
  • handful of acceptance tests for validation

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (3bb2d55) to head (4aec104).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
minikube/resource_cluster.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   79.21%   79.67%   +0.45%     
==========================================
  Files          14       15       +1     
  Lines        1126     1166      +40     
==========================================
+ Hits          892      929      +37     
- Misses        202      204       +2     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-the-programmer scott-the-programmer marked this pull request as ready for review October 12, 2024 13:02
@scott-the-programmer scott-the-programmer merged commit c55e199 into main Oct 12, 2024
2 checks passed
@scott-the-programmer scott-the-programmer deleted the wait-for-components branch October 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add wait for add_ons to become available

2 participants