prevent equivalent disk_size values from causing cluster replacement #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-the-programmer
force-pushed
the
bug/disk_size_diff
branch
2 times, most recently
from
a9f600f to
fddff56
Compare
scott-the-programmer
force-pushed
the
bug/disk_size_diff
branch
2 times, most recently
from
6d3b9c8 to
7969d86
Compare
scott-the-programmer
force-pushed
the
bug/disk_size_diff
branch
from
be13fd0 to
3ea4a11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 79.67% 79.67%
=======================================
Files 15 15
Lines 1166 1166
=======================================
Hits 929 929
Misses 204 204
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176
This PR applies the same conversion / validation function that we apply for
memorytodisk_sizeproperty. The result is that applying equivalent values (i.e.10240mand10g) result in a no-op