Upgrade to minikube 1.35 #197
Conversation
|
Caution Review failedThe pull request is closed. """ WalkthroughThe changes update Kubernetes and Minikube version references throughout the project, including provider configurations, schema defaults, and Go module dependencies. Descriptions for schema attributes were also refined, notably expanding GPU support options and updating documentation to reflect the latest stable Kubernetes versions. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
minikube/version/version.go (1)
4-4: Version constant bump to v1.35.0
TheVersionconstant now reflects Minikube v1.35.0. Consider updating the CHANGELOG or release notes to document this version change.minikube/schema_cluster.go (1)
602-604: Nit: Clarify the schema default for Kubernetes version.The description states “Defaults to 'stable'” but the schema
Defaultis set to an empty string (""). Consider either:
- Setting
Default: "stable"explicitly, or- Amending the description to note that an empty value resolves to stable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
examples/guides/terragrunt/terragrunt_project/_envcommon/minikube.hcl(1 hunks)examples/provider/provider.tf(1 hunks)examples/resources/minikube_cluster/resource.tf(1 hunks)go.mod(1 hunks)minikube/schema_cluster.go(3 hunks)minikube/version/version.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (6)
go.mod (1)
17-17: Version bump to Minikube v1.35.0
Thek8s.io/minikubemodule dependency has been correctly updated fromv1.34.0tov1.35.0, aligning with the intended upgrade. Ensure you rungo mod tidyto clean up any stale dependencies and validate the module graph.examples/provider/provider.tf (1)
2-2: Update Kubernetes version in provider
Thekubernetes_versionhas been bumped to"v1.30.2"to stay consistent with the latest stable release. This matches the PR objectives and other example configurations.examples/resources/minikube_cluster/resource.tf (1)
2-2: Synchronize Kubernetes version across examples
Updatedkubernetes_versionto"v1.30.2", maintaining consistency with the provider and Terragrunt examples.examples/guides/terragrunt/terragrunt_project/_envcommon/minikube.hcl (1)
4-4: Terragrunt Kubernetes version update
Thekubernetes_versionlocal has been correctly updated to"v1.30.2", ensuring all sample environments use the same Kubernetes release.minikube/schema_cluster.go (2)
138-141: Approve base_image version bump and digest update.The default image has been correctly updated to
v0.0.46with the matching SHA256 digest, aligning with the new Minikube release.
417-421: GPU options description expanded correctly.The description now includes AMD GPUs alongside NVIDIA (
[all,nvidia,amd]), accurately reflecting the enhanced support.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 18 18
Lines 1305 1305
=======================================
Hits 1029 1029
Misses 239 239
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request updates the Kubernetes version used across the project, aligns dependencies with the latest Minikube release, and introduces minor enhancements to the Minikube schema. Below is a breakdown of the most significant changes:
Kubernetes Version Updates:
kubernetes_versiontov1.30.2inminikube.hcl,provider.tf, andresource.tfto ensure consistency across configurations. [1] [2] [3]Dependency Updates:
k8s.io/minikubedependency fromv1.34.0tov1.35.0ingo.mod.version.gotov1.35.0to match the updated Minikube dependency.Minikube Schema Enhancements:
kicbaseimage tov0.0.46with a new SHA256 hash for improved container image stability.kubernetes_versionto reflect the latest stable version (v1.32.0).Summary by CodeRabbit
New Features
Bug Fixes
Chores