Skip to content

set api server port on both kube config and node config #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

set api server port on both kube config and node config #205

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e81aa
set api server port on both kube config and node config
scott-the-programmer Jul 29, 2025
c2e8cf6
Merge branch 'main' into bug/api-server-port
scott-the-programmer Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions minikube/resource_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ func initialiseMinikubeClient(d *schema.ResourceData, m interface{}) (lib.Cluste
apiserverNames = state_utils.ReadSliceState(d.Get("apiserver_names"))
}

apiserverPort := d.Get("apiserver_port").(int)

networkPlugin := d.Get("network_plugin").(string) // This is a deprecated parameter in Minikube, however,
// it is still used internally, so we need to set it to a default value if it is not set. We should expect
// this to be a blank string usually, which should default to cni
Expand Down Expand Up @@ -334,7 +336,7 @@ func initialiseMinikubeClient(d *schema.ResourceData, m interface{}) (lib.Cluste

n := config.Node{
Name: "",
Port: 8443,
Port: apiserverPort,
KubernetesVersion: k8sVersion,
ContainerRuntime: containerRuntime,
ControlPlane: true,
Expand Down Expand Up @@ -378,7 +380,7 @@ func initialiseMinikubeClient(d *schema.ResourceData, m interface{}) (lib.Cluste

cc := config.ClusterConfig{
Addons: addonConfig,
APIServerPort: d.Get("apiserver_port").(int),
APIServerPort: apiserverPort,
Name: d.Get("cluster_name").(string),
KeepContext: d.Get("keep_context").(bool),
EmbedCerts: d.Get("embed_certs").(bool),
Expand Down