Skip to content

apiserver_ips not applied to API server certificate SANs when using docker driver #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

apiserver_ips not applied to API server certificate SANs when using docker driver #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion minikube/generator/schema_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func (m *MinikubeHostBinary) GetStartHelpText(ctx context.Context) (string, erro
}

var computedFields []string = []string{
"apiserver_ips",
"apiserver_names",
"hyperkit_vsock_ports",
"insecure_registry",
Expand Down
11 changes: 10 additions & 1 deletion minikube/resource_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"net"
"sort"
"strconv"
"time"
Expand Down Expand Up @@ -293,6 +294,13 @@ func initialiseMinikubeClient(d *schema.ResourceData, m interface{}) (lib.Cluste
apiserverNames = state_utils.ReadSliceState(d.Get("apiserver_names"))
}

var apiServerIPs []net.IP
if v, ok := d.GetOk("apiserver_ips"); ok {
for _, ip := range v.(*schema.Set).List() {
apiServerIPs = append(apiServerIPs, net.ParseIP(ip.(string)))
}
}

apiserverPort := d.Get("apiserver_port").(int)

networkPlugin := d.Get("network_plugin").(string) // This is a deprecated parameter in Minikube, however,
Expand Down Expand Up @@ -322,6 +330,7 @@ func initialiseMinikubeClient(d *schema.ResourceData, m interface{}) (lib.Cluste
Namespace: d.Get("namespace").(string),
APIServerName: d.Get("apiserver_name").(string),
APIServerNames: apiserverNames,
APIServerIPs: apiServerIPs,
DNSDomain: d.Get("dns_domain").(string),
FeatureGates: d.Get("feature_gates").(string),
ContainerRuntime: containerRuntime,
Expand Down Expand Up @@ -462,4 +471,4 @@ func initialiseMinikubeClient(d *schema.ResourceData, m interface{}) (lib.Cluste
})

return clusterClient, nil
}
}