#221 Propagating insecure registry through the provider #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for the contribution! LGTM A few tests failing which I can fix up while working on #219 |
scott-the-programmer
merged commit d8c5e20
into
scott-the-programmer:main
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in the insecure registries to the schema. Not entirely sure when I ran
make configureit removed the terragrunt docs - so put it back to the baseline.Also not entirely sure what I have missed to get the definition of the new
insecure_registrykey in the generated docs.Have tested this on a 1.31 (well actually 3 of them spun up in hub, spoke, spoke) cluster - using an external registry signed with a self signed CA. Workloads able to pull from this registry.