Skip to content

Support legend #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support legend #250

wants to merge 1 commit into from

Conversation

Folyd
Copy link

@Folyd Folyd commented Jun 27, 2021

This PR simply adds Legend support.

Here is the screenshot:

image

@mrbrianevans
Copy link

Very nice feature.

One issue I've found with the implementation is that the labels in the legend don't use the fontColor prop passed to SvelteHeatmap. This results in inconsistent colors of the labels.

Example below:
image

All the labels are white, as this was passed to fontColor prop, but the legend labels are still the default black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Folyd @mrbrianevans