Skip to content

fix for final character of column not being '@' #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for final character of column not being '@' #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@
<script>
$(function() {
$("#example1").figlet("Figlet JS");
$("#example2").figlet("jQuery plugin", "drpepper");
$("#example2").figlet("jQuery", "drpepper");
$("#example3").figlet("plugin","roman");
});
</script>
</head>
<body>

<pre id="example1"></pre>
<pre id="example2"></pre>
<pre id="example3"></pre>

</body>
</html>
Expand Down
11 changes: 7 additions & 4 deletions figlet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@ var Figlet = (typeof exports !== "undefined" ? exports : window).Figlet = {
header = lines[0].split(" "),
hardblank = header[0].charAt(header[0].length - 1),
height = +header[1],
comments = +header[5];
comments = +header[5],
firstline = lines[comments+1],
finalchar = firstline.charAt(firstline.length - 1);

Figlet.fonts[name] = {
defn: lines.slice(comments + 1),
hardblank: hardblank,
hardblank: hardblank,
finalchar: finalchar,
height: height,
char: {}
};
Expand All @@ -52,8 +55,8 @@ var Figlet = (typeof exports !== "undefined" ? exports : window).Figlet = {
i;
for (i = 0; i < height; i++) {
charDefn[i] = fontDefn.defn[start + i]
.replace(/@/g, "")
.replace(RegExp("\\" + fontDefn.hardblank, "g"), " ");
.replace(RegExp(fontDefn.finalchar,"g"), "")
.replace(RegExp("\\" + fontDefn.hardblank, "g"), " ");
}
return fontDefn.char[char] = charDefn;
},
Expand Down