Skip to content

Fix GIF duration and add other format support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KnowZero wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix GIF duration and add other format support #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a51b182
Fix GIF duration and add other format support
KnowZero Nov 10, 2020
15c1feb
Try to fix non-video first streams
KnowZero Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 43 additions & 15 deletions animationimporter/animationimporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Animationimporter(Extension):
# make sure these are defined at the top
def signal_change_location(self):

self.fileName = QFileDialog.getOpenFileName(self.dialog, "Select your Video File", "", "Videos(*.mp4 *.avi *.mpg, *.gif);; All files (*.*)" )
self.fileName = QFileDialog.getOpenFileName(self.dialog, "Select your Video File", "", "Videos(*.mp4 *.avi *.mpg *.webm *.ogv *.mkv *.mpg, *.gif);; All files (*.*)" )


# if the person hits Cancel while picking a file, return and stop trying to load anything
Expand All @@ -39,7 +39,7 @@ def signal_change_location(self):
# run FFProbe to get vidoe info
self.findVideoMetada(self.fileName[0])

# print(ffprobeOutput['streams'][0]['height'])
# print(ffprobeOutput['streams'][self.onStream]['height'])
self.textInfo = "Width:" + str(self.ffprobeData_width) + "px" + "<br>"
self.textInfo += "Height:" + str(self.ffprobeData_height) + "px" + "<br>"
self.textInfo += "Duration: " + str( '%.2f'%( self.ffprobeData_totalVideoDuration) ) + " s" + "<br>"
Expand Down Expand Up @@ -234,36 +234,64 @@ def start_video_processing(self):

# function to find the resolution of the input video file
def findVideoMetada(self, pathToInputVideo):
self.cmd = "ffprobe -v quiet -print_format json -show_streams"
self.cmd = "ffprobe -v quiet -print_format json -show_streams -show_entries format"
self.args = shlex.split(self.cmd)
self.args.append(pathToInputVideo)

# run the ffprobe process, decode stdout into utf-8 & convert to JSON
self.ffprobeOutput = subprocess.check_output(self.args).decode('utf-8')

self.ffprobeOutput = json.loads(self.ffprobeOutput)
self.ffprobeData_height = self.ffprobeOutput['streams'][0]['height']
self.ffprobeData_width = self.ffprobeOutput['streams'][0]['width']

for i in range(len(self.ffprobeOutput['streams'])):
if self.ffprobeOutput['streams'][i]['codec_type'] == 'video':
self.onStream = i
break

self.ffprobeData_height = self.ffprobeOutput['streams'][self.onStream]['height']
self.ffprobeData_width = self.ffprobeOutput['streams'][self.onStream]['width']

# frame rate comes back in odd format...so we need to do a bit of work so it is more usable.
# data will come back like "50/3"
rawFrameRate = self.ffprobeOutput['streams'][0]['r_frame_rate']
rawFrameRate = self.ffprobeOutput['streams'][self.onStream]['r_frame_rate']
self.ffprobeData_frameRate = int(rawFrameRate.split("/")[0]) / int(rawFrameRate.split("/")[1])
self.ffprobeData_frameRate = math.ceil(self.ffprobeData_frameRate)

# GIF does not bring back duration/frame data so use count_frames
if self.ffprobeOutput['streams'][self.onStream]['codec_name'] == 'gif':
self.cmd = "ffprobe -v quiet -print_format json -count_frames -show_streams"
self.args = shlex.split(self.cmd)
self.args.append(pathToInputVideo)
self.ffprobeOutput = subprocess.check_output(self.args).decode('utf-8')

if "gif" in pathToInputVideo: # gif stores total frame count elsewhere
# maybe first part of frame rate for GIF?
self.ffprobeData_totalFrameCount = int(rawFrameRate.split("/")[0])
self.ffprobeOutput = json.loads(self.ffprobeOutput)
self.ffprobeData_totalFrameCount = int(self.ffprobeOutput['streams'][0]['nb_read_frames'])
self.ffprobeData_totalVideoDuration = float(self.ffprobeData_totalFrameCount/self.ffprobeData_frameRate)
else:
self.ffprobeData_totalFrameCount = int(self.ffprobeOutput['streams'][0]['nb_frames'])

# Get duration from stream, if it doesn't exist such as on VP8 and VP9, try to get it out of format
if self.ffprobeOutput['streams'][self.onStream].get('duration') is not None:
self.ffprobeData_totalVideoDuration = float(self.ffprobeOutput['streams'][self.onStream]['duration'])
elif self.ffprobeOutput['format'].get('duration') is not None:
self.ffprobeData_totalVideoDuration = float(self.ffprobeOutput['format']['duration'])
else:
# If no duration is found with ffprobe, decode with ffmpeg instead for formats such as mpg.
# This could be really slow for large files so probably a load screen is needed
self.cmdAlt = "ffmpeg -hide_banner -stats -f null - -i"
self.argsAlt = shlex.split(self.cmdAlt)
self.argsAlt.append(pathToInputVideo)
self.ffprobeOutputAlt = subprocess.check_output(self.argsAlt, stderr= subprocess.STDOUT).decode('utf-8')

self.ffprobeData_altOutputTime = self.ffprobeOutputAlt[ self.ffprobeOutputAlt.find('time=')+5 : self.ffprobeOutputAlt.find('bitrate=')-1 ].split(':')
self.ffprobeData_totalVideoDuration = float( (int(self.ffprobeData_altOutputTime[0]) * (60*60)) + (int(self.ffprobeData_altOutputTime[1]) * (60)) + float(self.ffprobeData_altOutputTime[2]))
self.ffprobeData_totalFrameCount = int(self.ffprobeOutputAlt[ self.ffprobeOutputAlt.find('frame=')+6 : self.ffprobeOutputAlt.find('fps=')-1 ].strip())

# Get nb_frames from stream, if it doesn't exist such as on OGV, try to estimate it out of frame rate
if self.ffprobeOutput['streams'][self.onStream].get('nb_frames') is not None:
self.ffprobeData_totalFrameCount = int(self.ffprobeOutput['streams'][self.onStream]['nb_frames'])
elif self.ffprobeData_frameRate > 0:
self.ffprobeData_totalFrameCount = math.ceil(self.ffprobeData_frameRate * self.ffprobeData_totalVideoDuration)

# GIF does not bring back duration/frame data...so need to figure it out
if "gif" in pathToInputVideo:
self.ffprobeData_totalVideoDuration = float(self.ffprobeData_totalFrameCount/self.ffprobeData_frameRate)
else:
self.ffprobeData_totalVideoDuration = float(self.ffprobeOutput['streams'][0]['duration'])


# sometimes frame rate is not set right in video.
Expand Down