Skip to content

Conversation

@advance512
Copy link

Added support for receiving HTML input
Fixed issue with dimensions(tag) not working for some websites

Fixed issue with dimensions(tag) not working for some websites
Copy link
Owner

@scottwernervt scottwernervt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why the Travis CI is not showing up in gitlab checks but there are some errorshttps://travis-ci.org/github/scottwernervt/favicon/builds/699454421.

The py27 test is failing so I think we might have to move html_override arg in front of *args.

@advance512
Copy link
Author

I am not sure why the Travis CI is not showing up in gitlab checks but there are some errorshttps://travis-ci.org/github/scottwernervt/favicon/builds/699454421.

The py27 test is failing so I think we might have to move html_override arg in front of *args.

Unfortunately we can't do that, as that will mean that code like this:

favicon.get('http://mock.com/', headers)

will see the headers as the html parameter and break. Putting the html parameter after the args* means it becomes a keyword only argument, which solves it.
Alternatively, we can modify the version to show non-comaptibility, or drop Python 2.x support (it is EOL'd after all).

Change: test corrected and minimized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants