Skip to content

BUGFIX #357: Bug using "unique_fields" on update#358

Open
bvrignaud wants to merge 4 commits intoscoumbourdis:masterfrom
bvrignaud:master
Open

BUGFIX #357: Bug using "unique_fields" on update#358
bvrignaud wants to merge 4 commits intoscoumbourdis:masterfrom
bvrignaud:master

Conversation

@bvrignaud
Copy link
Contributor

This is a correction for the bug #357.

@bvrignaud
Copy link
Contributor Author

Is there any problem to apply my PR ?

@franciscofruiz
Copy link

Hello, there is still the bug #357. You already fixed it in BUGFIX , you changed
- if(!isset($row->$field_name))
+ if(!property_exists($row, $field_name)) and it worked fine.
rollbacked here: BUGFIX #396

@scoumbourdis
Copy link
Owner

I will test the pull request and get back with some feedback. It seems to complicated to just merge it to be honest. I have to do some proof of concepts first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants