Add option to remove elements that are set as hidden#327
Open
nielstron wants to merge 2 commits intoscour-project:masterfrom
Open
Add option to remove elements that are set as hidden#327nielstron wants to merge 2 commits intoscour-project:masterfrom
nielstron wants to merge 2 commits intoscour-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this cool project!
I was missing one usecase where I have SVG files with hidden pngs/images as source (being traced for vectorization or otherwise helping during design) and expected scour to automatically remove it.
This PR adds that option. I do not enable it by default as I don't know if this can potentially mess up layouts if they rely on hidden elements for referencing/anchoring.