Skip to content

Conversation

keynmol
Copy link

@keynmol keynmol commented Oct 4, 2025

My understanding is that this should be enough for publishing as long as the credentials in this repo have been rotate since the Central Portal migratio.

@ckipp01
Copy link
Member

ckipp01 commented Oct 5, 2025

Thanks @keynmol! But with the sbt update there are some changes with the way all the cross versions are set up. That's where the work actually is, and I didn't have time to dig into.

@keynmol
Copy link
Author

keynmol commented Oct 5, 2025

I am assuming that SBT 1.7.0 is the one introducing changes to how cross versions work:

https://github.com/sbt/sbt/releases/tag/v1.7.0

. In sbt 1.7.0, a concrete version such as ++ 3.0.1 requires exact version to be present in crossScalaVersion.

Which is in contrast with the way runtime and reporter are set up in this project.

I added a couple of hacks to see how the tests go (they pass locally), but we can think of an actual fix

libraryDependencies += "org.scala-lang" % "scala-compiler" % scalaVersion.value % Provided,
sharedSettings
sharedSettings,
allowUnsafeScalaLibUpgrade := true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also set runtime to have allowUnsafeScalaLibUpgrade := true,, we should be ok to do that.

Or alternatively ask Seb to release Scala JS 2.13.17 on 1.19.0

Alternatively, do we need to cross publish JS on every Scala version as well?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckipp01 if you'd like I can help with day to day maintenance, is it possible to add me to the repo?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala.js 1.20.1 support for 2.13.17 is published.

We will not publish earlier versions, as they predate the Sonatypocalypse. Their build cannot publish to the new Central Portal.

https://contributors.scala-lang.org/t/scala-2-13-17-release-planning/6994/18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants