Use SHUB_VIRTUAL_SPIDER as spider name when available#462
Merged
VMRuiz merged 5 commits intoscrapinghub:masterfrom Apr 11, 2025
Merged
Use SHUB_VIRTUAL_SPIDER as spider name when available#462VMRuiz merged 5 commits intoscrapinghub:masterfrom
VMRuiz merged 5 commits intoscrapinghub:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 79.58% 79.69% +0.11%
==========================================
Files 76 77 +1
Lines 3242 3251 +9
Branches 321 321
==========================================
+ Hits 2580 2591 +11
+ Misses 593 591 -2
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VMRuiz
requested changes
Apr 7, 2025
Collaborator
VMRuiz
left a comment
VMRuiz
left a comment
There was a problem hiding this comment.
This is a backward incompatible change. We should include an explanation somewhere on the docs.
VMRuiz
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.