Conversation
There was a problem hiding this comment.
Pull request overview
This is a comprehensive modernization PR that updates the spidermon project infrastructure and codebase. The changes include:
Changes:
- Migration from setup.py to pyproject.toml with modern build backend (hatchling)
- Dropped Python 3.8/3.9 support, added Python 3.13/3.14 support, minimum now Python 3.10
- Extensive code modernization: type hints, f-strings, pathlib, modern Python idioms
- CI/CD updates: ubuntu-latest, updated action versions, new tox environments for mypy and docs
- Test infrastructure improvements: pytest-importorskip usage, async test support, better fixtures
- Documentation updates: restructured docs directory, updated links, fixed references
Reviewed changes
Copilot reviewed 174 out of 194 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | New: Modern project configuration with hatchling, ruff linting, mypy, coverage settings |
| setup.py, setup.cfg, .bumpversion.cfg, MANIFEST.in | Removed: Legacy packaging files |
| tox.ini | Modernized: Added mypy/docs environments, updated Python versions, improved test configuration |
| .github/workflows/* | Updated: CI workflow modernization, new publish workflow with trusted publishing |
| .pre-commit-config.yaml | Updated: Replaced black with ruff, added additional hooks |
| spidermon/**/*.py | Modernized: Type hints, f-strings, pathlib, ClassVar, improved error handling |
| tests/**/*.py | Improved: pytest.importorskip for optional dependencies, async support, better fixtures |
| docs/** | Updated: Fixed broken links, restructured directory, updated sphinx configuration |
| to-do.txt | Removed: Obsolete TODO file |
| examples/** | Modernized: Type hints and modern Python syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wRAR
reviewed
Feb 17, 2026
| | ``premailer >= 2.7.0`` | ||
| | ``requests >= 2.19.0`` | ||
| | ``scrapinghub >= 2.4.0`` | ||
| | ``scrapinghub-entrypoint-scrapy >= 0.11.2`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #467.
Changes include:
monitoringextra. The extra is only run with minimum and latest versions of dependencies.Things I considered but did not implement:
spidermonnot depending onscrapyunless installed withmonitoring.