Skip to content

Coroutine handler for engine_started signal#360

Merged
elacuesta merged 1 commit intomainfrom
engine-started-signal-coroutine-handler
Jan 19, 2026
Merged

Coroutine handler for engine_started signal#360
elacuesta merged 1 commit intomainfrom
engine-started-signal-coroutine-handler

Conversation

@elacuesta
Copy link
Member

2026-01-19 12:01:23 [py.warnings] WARNING: /.../lib/python3.12/site-packages/scrapy/utils/signal.py:185: ScrapyDeprecationWarning: scrapy_playwright.handler.ScrapyPlaywrightDownloadHandler._engine_started returned a Deferred, this is deprecated. Please refactor this function to return a coroutine.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.89%. Comparing base (1ade940) to head (b54fc46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files           6        6           
  Lines         646      647    +1     
=======================================
+ Hits          613      614    +1     
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elacuesta elacuesta merged commit 8cb31c1 into main Jan 19, 2026
16 of 17 checks passed
@elacuesta elacuesta deleted the engine-started-signal-coroutine-handler branch January 19, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant