Skip to content

Commit e857eef

Browse files
committed
Address feedback and make test_higher_concurrency more resilient
1 parent 2c93743 commit e857eef

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

scrapy_zyte_api/_middlewares.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
_LOG_DEFERRED_IS_DEPRECATED,
1414
_close_spider,
1515
_schedule_coro,
16+
maybe_deferred_to_future,
1617
)
1718

1819
logger = getLogger(__name__)
@@ -188,7 +189,13 @@ def __init__(self, crawler):
188189
if _LOG_DEFERRED_IS_DEPRECATED:
189190
self._send_signal = crawler.signals.send_catch_log_async
190191
else:
191-
self._send_signal = crawler.signals.send_catch_log_deferred
192+
193+
async def _send_signal(signal, **kwargs):
194+
await maybe_deferred_to_future(
195+
crawler.signals.send_catch_log_deferred(signal, **kwargs)
196+
)
197+
198+
self._send_signal = _send_signal
192199

193200
@staticmethod
194201
def _get_header_set(request):

tests/test_api_requests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ async def test_higher_concurrency():
339339
response_indexes = []
340340
expected_first_index = concurrency - 1
341341
fast_seconds = 0.001
342-
slow_seconds = 0.2
342+
slow_seconds = 0.4
343343

344344
def _build_request(index: int) -> Request:
345345
return Request(

0 commit comments

Comments
 (0)