Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements serialization support for web-poet page input types (Actions, Geolocation, Screenshot) to enable proper persistence and reconstruction of these objects. The serializers convert objects to/from a dictionary format suitable for storage or transmission.
- Adds
_serialization.pymodule with serialize/deserialize functions for Actions, Geolocation, and Screenshot - Registers the serializers with web-poet's serialization system
- Imports the serialization module in
__init__.pyto ensure registration happens at package import time
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scrapy_zyte_api/_serialization.py | New module defining serialization/deserialization functions for Actions, Geolocation, and Screenshot classes |
| scrapy_zyte_api/init.py | Imports the serialization module to trigger registration of serializers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 97.33% 97.36% +0.03%
==========================================
Files 14 15 +1
Lines 1916 1939 +23
Branches 356 356
==========================================
+ Hits 1865 1888 +23
Misses 25 25
Partials 26 26
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Test issues have been addressed by #269, and are unrelated. |
No description provided.