Add tests for extract_regex and shorten edge cases#332
Merged
Gallaecio merged 2 commits intoscrapy:masterfrom Dec 26, 2025
Merged
Add tests for extract_regex and shorten edge cases#332Gallaecio merged 2 commits intoscrapy:masterfrom
Gallaecio merged 2 commits intoscrapy:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 5 5
Lines 436 436
Branches 76 76
=======================================
Hits 415 415
Misses 13 13
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@wRAR, could you please review this PR? |
Contributor
Author
|
Hi @wRAR, just a gentle reminder to review this PR when you get a chance. It’ll help me proceed with writing the next test. Thanks |
1 similar comment
Contributor
Author
|
Hi @wRAR, just a gentle reminder to review this PR when you get a chance. It’ll help me proceed with writing the next test. Thanks |
wRAR
requested changes
Dec 24, 2025
wRAR
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two missing tests to improve coverage: