Skip to content

Comments

Add tests for extract_regex and shorten edge cases#332

Merged
Gallaecio merged 2 commits intoscrapy:masterfrom
IkramKhanNiazi:add-utils-edge-case-tests
Dec 26, 2025
Merged

Add tests for extract_regex and shorten edge cases#332
Gallaecio merged 2 commits intoscrapy:masterfrom
IkramKhanNiazi:add-utils-edge-case-tests

Conversation

@IkramKhanNiazi
Copy link
Contributor

Adds two missing tests to improve coverage:

  • Tests extract_regex() when regex with 'extract' named group returns no match
  • Tests shorten() function with custom suffix parameter (previously only the default was tested)

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (fd183dd) to head (164365c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files           5        5           
  Lines         436      436           
  Branches       76       76           
=======================================
  Hits          415      415           
  Misses         13       13           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IkramKhanNiazi
Copy link
Contributor Author

@wRAR, could you please review this PR?
Thanks

@IkramKhanNiazi
Copy link
Contributor Author

Hi @wRAR, just a gentle reminder to review this PR when you get a chance. It’ll help me proceed with writing the next test. Thanks

1 similar comment
@IkramKhanNiazi
Copy link
Contributor Author

Hi @wRAR, just a gentle reminder to review this PR when you get a chance. It’ll help me proceed with writing the next test. Thanks

@IkramKhanNiazi IkramKhanNiazi requested a review from wRAR December 25, 2025 05:52
@Gallaecio Gallaecio merged commit 612e605 into scrapy:master Dec 26, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants