Type hints based on #61 #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 95.3% 95.54% +0.23%
==========================================
Files 7 8 +1
Lines 469 494 +25
Branches 93 93
==========================================
+ Hits 447 472 +25
Misses 15 15
Partials 7 7
|
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 95.3% 95.54% +0.23%
==========================================
Files 7 8 +1
Lines 469 494 +25
Branches 93 93
==========================================
+ Hits 447 472 +25
Misses 15 15
Partials 7 7
|
Member
Author
|
@kmike could you please take a look? |
Member
Author
|
Closed. There are quite some changes on the master branch, especially python 2 support is dropped. New pr in #172 . |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is based on @kmike 's work in #61.
I wanted to set the pr target to the
type-hintbranch but since it has conflicts with master I'm not able to do that. So I have to set the pr target branch tomaster.