-
Notifications
You must be signed in to change notification settings - Fork 106
switch from pytest-flake8 to raw flake8; clean up ignores #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
13cc938
switch from pytest-flake8 to raw flake8; clean up ignores
kmike 9ed2318
rerun black; silence flake8 when it disagrees with black
kmike 5859d57
bump mypy version, just in case
kmike ec5d84c
Fix flake E401
kmike c394ec4
move flake8 arguments to posargs in tox.ini
kmike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [flake8] | ||
| ignore = | ||
| # Refers to the max-line length. Let's suppress the error and simply | ||
| # let black take care on how it wants to format the lines. | ||
| E501, | ||
|
|
||
| # Refers to "line break before/after binary operator". | ||
| # Similar to above, let black take care of the formatting. | ||
| W503, | ||
| W504, | ||
|
|
||
| # black disagrees with flake8, and inserts whitespace | ||
| E203, # whitespace before ':' | ||
|
|
||
| # It seems flake8 can misfire on it | ||
| E401, # multiple imports on one line | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,2 @@ | ||
| [pytest] | ||
| doctest_optionflags = ALLOW_UNICODE ALLOW_BYTES | ||
| flake8-max-line-length = 88 | ||
| flake8-ignore = | ||
| W503 # https://www.flake8rules.com/rules/W503.html | ||
| E203 # https://www.flake8rules.com/rules/E203.html | ||
|
|
||
| docs/conf.py E121 E122 E265 E401 | ||
| tests/test_encoding.py E128 E221 E241 E302 E401 E501 E731 | ||
| tests/test_form.py E265 | ||
| tests/test_html.py E123 E128 E241 E303 E501 E502 | ||
| tests/test_http.py E128 E261 E302 W291 | ||
| tests/test_url.py E126 E127 E128 E226 E261 E303 E501 W293 W391 | ||
| w3lib/encoding.py E126 E128 E302 E305 E401 E501 | ||
| w3lib/form.py E402 E501 E721 | ||
| w3lib/html.py E128 E302 E501 E502 W504 | ||
| w3lib/http.py E501 | ||
| w3lib/url.py E128 E261 E302 E305 E501 F841 W291 W293 W504 | ||
| w3lib/util.py E302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.