Skip to content

Commit b8c7c37

Browse files
fix: [UEPR-56] address review comments
1 parent 7546200 commit b8c7c37

File tree

5 files changed

+7
-10
lines changed

5 files changed

+7
-10
lines changed

packages/scratch-gui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"i18n:push": "tx-push-src scratch-editor interface translations/en.json",
4747
"i18n:src": "rimraf ./translations/messages/src && babel src > tmp.js && rimraf tmp.js && build-i18n-src ./translations/messages/src ./translations/",
4848
"start": "webpack serve",
49-
"test": "npm run test:lint && npm run test:unit && npm run build && npm run test:integration",
49+
"test": "npm run test:lint && npm run test:unit && npm run test:integration",
5050
"test:integration": "cross-env JEST_JUNIT_OUTPUT_NAME=integration-tests-results.xml jest --maxWorkers=4 test[\\\\/]integration",
5151
"test:lint": "eslint . --ext .js,.jsx,.ts,.tsx",
5252
"test:unit": "cross-env JEST_JUNIT_OUTPUT_NAME=unit-tests-results.xml jest test[\\\\/]unit",

packages/scratch-gui/src/components/context-menu/context-menu.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
z-index: $z-index-context-menu;
1515
}
1616

17-
.menu-item{
17+
.menu-item {
1818
font-size: 13px;
1919
line-height: 1;
2020
display: flex;
@@ -29,7 +29,7 @@
2929
color: $text-primary;
3030
}
3131

32-
.menu-item[data-highlighted]{
32+
.menu-item[data-highlighted] {
3333
background: $looks-secondary;
3434
color: white;
3535
}

packages/scratch-gui/src/components/webgl-modal/webgl-modal.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ const WebGlModal = props => {
8181
<FormattedMessage
8282
defaultMessage="FAQ"
8383
description="link to Scratch 3.0 FAQ page"
84-
id="gui.unsupportedBrowser.previewfaqlinktext"
84+
id="gui.webglModal.previewfaqlinktext"
8585
/>
8686
),
8787
a: previewFaqLink => (

packages/scratch-gui/src/containers/sprite-selector-item.jsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,7 @@ class SpriteSelectorItem extends React.PureComponent {
127127
this.setState({isDeletePromptOpen: false});
128128
}
129129
setRef (component) {
130-
// The ref is on the element inside ContextMenu.Trigger
131-
if (component) {
132-
this.ref = component;
133-
}
130+
this.ref = component;
134131
}
135132
render () {
136133
const {

packages/scratch-gui/test/unit/components/controls.test.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('Controls component', () => {
2525
});
2626

2727
describe('triggers the right callbacks when clicked', () => {
28-
test('when green flag button clicked tirggers the right callback', () => {
28+
test('when green flag button clicked triggers the right callback', () => {
2929
const props = defaultProps();
3030
const { container } = renderWithIntl(<Controls {...props} />);
3131

@@ -35,7 +35,7 @@ describe('Controls component', () => {
3535
expect(props.onGreenFlagClick).toHaveBeenCalled();
3636
});
3737

38-
test('when stop all button clicked tirggers the right callback', () => {
38+
test('when stop all button clicked triggers the right callback', () => {
3939
const props = defaultProps();
4040
const { container } = renderWithIntl(<Controls {...props} />);
4141

0 commit comments

Comments
 (0)