fix: parse root dir even if inside a node_modules folder#76
Closed
KManolov3 wants to merge 1 commit intoscratchfoundation:mainfrom
Closed
fix: parse root dir even if inside a node_modules folder#76KManolov3 wants to merge 1 commit intoscratchfoundation:mainfrom
KManolov3 wants to merge 1 commit intoscratchfoundation:mainfrom
Conversation
Bogomil-Stoyanov
approved these changes
Jan 23, 2025
cwillisf
approved these changes
Jan 28, 2025
Contributor
Author
|
This fix is not needed anymore, since we are switching out from building GUI from node_modules in scratch-android |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
NOTE: This may not need to be merged in case scratch-android starts using scratch-gui from an npm package, instead of a git commit as it does currently.
A dependency for https://scratchfoundation.atlassian.net/browse/UEPR-139
Proposed Changes
Force babel to parse the root folder, even if inside a node_modules futher up the hierarchy.
Reason for Changes
In another repo -
scratch-android- we are manually buildingscratch-guiby going inside its folder (which is inside node_modules ofscratch-android) and making a webpack build. After the update ofscratch-guito usescratch-webpack-configthat stopped working, since currently there is a rule which prevents babel from parsing folders inside anode_modulesfolder. However that is not relative to the thepwdso if the project we are trying to build is inside anode_modulesfurther up the chain, babel will not transpile the necessary files (e.g. .jsx files).