feat: create conjugate app about tab #561#582
feat: create conjugate app about tab #561#582ashb155 wants to merge 4 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR finalizes the logic and layout for the About Screen specifically for the
CONJUGATEapp flavor, ensuring it matches the Figma design requirements and adds additional comprehensive tests for the same. It also additionally resolves edge-to-edge system UI light/dark mode bug.Changes included:
FlavorProviderto setisConjugateAppand passes it down togetCommunityListandgetFeedbackAndSupportList.isConjugateAppparameter tobuildCommunityListandfeedbackAndSupportListto conditionally serve Conjugate strings instead of the default Scribe ones.shareScribeto acceptisConjugateAppand generate flavor-specific share text and chooser title accordingly.isConjugateApp = trueandfalsestates.applyNavigationBarStylesimilar to the Keyboard flavor build.Screenshots
isConjugateApp = trueisConjugateApp = falseRelated issue