Skip to content

feat: create conjugate app about tab #561#582

Open
ashb155 wants to merge 4 commits intoscribe-org:mainfrom
ashb155:about-conjugate
Open

feat: create conjugate app about tab #561#582
ashb155 wants to merge 4 commits intoscribe-org:mainfrom
ashb155:about-conjugate

Conversation

@ashb155
Copy link
Contributor

@ashb155 ashb155 commented Mar 24, 2026

Contributor checklist


Description

This PR finalizes the logic and layout for the About Screen specifically for the CONJUGATE app flavor, ensuring it matches the Figma design requirements and adds additional comprehensive tests for the same. It also additionally resolves edge-to-edge system UI light/dark mode bug.

Changes included:

  • AboutScreen.kt : Reads FlavorProvider to set isConjugateApp and passes it down to getCommunityList and getFeedbackAndSupportList.
  • **AboutUtil.kt :**Added isConjugateApp parameter to buildCommunityList and feedbackAndSupportList to conditionally serve Conjugate strings instead of the default Scribe ones.
  • ShareHelper.kt : Updated shareScribe to accept isConjugateApp and generate flavor-specific share text and chooser title accordingly.
  • AboutUtilTest.kt: Added unit tests using MockK to verify the correct i18n string IDs are returned for both isConjugateApp = true and false states.
  • MainActivity.kt : Fixed the system navigation bar UI bug by adding applyNavigationBarStyle similar to the Keyboard flavor build.

Screenshots

isConjugateApp = true

Light Mode Dark Mode When Share Clicked
Light Mode Dark Mode Share Sheet

isConjugateApp = false

Light Mode Dark Mode When Share Clicked
Light Mode Dark Mode Share Sheet

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Mar 24, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@ashb155 ashb155 changed the title About conjugate feat: Create Conjugate app About tab #561 Mar 24, 2026
@ashb155 ashb155 changed the title feat: Create Conjugate app About tab #561 feat: create conjugate app about tab #561 Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Conjugate app About tab

1 participant