Updated scri.be website link in About tab

[prince-0408]

Fixes #572

This PR addresses two main issues related to the "View all Scribe apps" icon ( scribeKeyIcon ) in the About tab's Community section:

1. Inconsistent Icon Sizing: The scribeKeyIcon was appearing smaller and inconsistent with other icons in the About tab, leading to a suboptimal user experience.
2. EXC_BAD_ACCESS Crash: An EXC_BAD_ACCESS crash was occurring due to force unwrapping of optional CGImage properties within the image processing logic, particularly when handling certain image assets.
   Changes Implemented:

• Image Processing Extensions:
  • Added trimTransparentEdges() and fitInSquareCanvas() extensions to UIImage in AppExtensions.swift . These extensions provide robust methods for removing transparent padding and fitting images into a consistent square canvas, ensuring uniform sizing.
  • Modified UIImage.availableIconImage in AppExtensions.swift to utilize these new extensions specifically for scribeKeyIcon . This ensures the icon is properly processed before display.
• Content Mode Standardization:
  • Set iconImageView.contentMode = .scaleAspectFit in AboutTableViewCell.swift . This ensures that all icons within the About tab maintain their aspect ratio and are scaled appropriately within their bounds, preventing distortion.
• Crash Fix ( EXC_BAD_ACCESS ):
  • Implemented safe unwrapping using guard let for cgImage and cgImage.dataProvider?.data within the trimTransparentEdges() function in AppExtensions.swift . This prevents the EXC_BAD_ACCESS crash by gracefully handling cases where image data might be nil .
• Icon Size Adjustment:
  • Adjusted the targetSize for scribeKeyIcon in AppExtensions.swift (to 32x32 for iPad and 28x28 for iPhone) based on user feedback to ensure it is visually balanced with other icons.

[github-actions]

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Thanks for the PR, @prince-0408! Would you be able to fix the swiftlint errors? :)

[prince-0408]

Sure

[andrewtavis]

note: This looks like changes for your other PR, @prince-0408 :) Could we remove this from this PR?

[prince-0408]

sure, on it.

[andrewtavis]

praise: Thanks for the great work to bring this in, @prince-0408! Really is nice to have you working on so many issues :)

note: I made the decision that all of this extra work for the icon scaling isn't really worth it. It'd be best to simply switch the icon to a globe, which I've done just now 😊

[andrewtavis]

note: The text has also been updated to "Visit the Scribe website", with this being updated on Figma and in all locales :)