Download language list

[catreedle]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the xcodebuild and swiftlint --strict commands as directed in the testing section of the contributing guide

---

Description

This PR implements the download language selection and confirmation flow for the Download Data screen.

Changes:

• Add download language list with all installed keyboards (DownloadDataScreen.swift)
• Add download button for each language (DownloadButton.swift)
• Add confirmation dialog when clicking download button (DownloadDataScreen.swift)
• Implement navigation from download screen to translation source language settings (InstallationVC.swift, SelectionViewTemplateViewController.swift
• Fix translation source language display by passing parentSection to cells before configuration (WrapperCell.swift and TableViewTemplateViewController.swift)
• Create Download State Manager to handle download logic
• Add view for "no installed keyboard" state

Related issue

• Closes Add download data menu button #567

[github-actions]

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[catreedle]

hi @andrewtavis, this is still work in progress, but open for review when you have the time :)

[andrewtavis]

So far the menu navigation and all else is functioning quite well, @catreedle! Please let us know if you have questions or need support 😊

[catreedle]

So far the menu navigation and all else is functioning quite well, @catreedle! Please let us know if you have questions or need support 😊

sure!
There's a navigation stack issue between the download language screen and translation source settings. When navigating between these screens, the download language screen gets duplicated in the navigation stack. This causes the back button to either:

• Return to the download language screen again (instead of going to Installation), or
• Sometimes navigate to the translation source settings screen

Ideally, pressing back should take the user directly to the Installation screen (let me know if I'm wrong about this). I plan to investigate this further, but any guidance or support would be appreciated. 😊

[catreedle]

hi @andrewtavis, I have a question about the expected behavior when the app is backgrounded and reopened.
Previously, the app always returned to the main Installation screen when reopened. Now that the Download screen is part of the Installation tab's navigation stack, it has become the entry point when it's in the navigation history (instead of the main Installation screen).
I think this might help if the user just adds some keyboards in the settings, when they open they can go straight to download the data. What do you think about this? Could this be the intended behavior or should we always reset to the main Installation screen?

[andrewtavis]

Hey @catreedle 👋 Answering your question above here in the sync for documentation :) I do agree that we would always want the back button of the download data page to go to the installation page. If we can figure this out, then that would be ideal :)

[henrikth93]

Looks good to me