Operator added to the widget#27
Operator added to the widget#27mustela wants to merge 4 commits intoscribu:masterfrom mustela:master
Conversation
The operator was added to the widget, now you can choose between add/in http://wordpress.org/support/topic/list-view-does-not-update-correctly
walkers.php
Outdated
There was a problem hiding this comment.
I'm not proud of these lines, since I think it can be written much better.
There was a problem hiding this comment.
Sunny days and lot of work! :P, but I'll improve it :)
Small fixes
|
The 'operator' field doesn't seem to have any effect in 'lists' mode. |
widget.php
Outdated
There was a problem hiding this comment.
Operator: seems vague; it should either be Operator between terms: or Operator between taxonomies:.
|
@scribu do you have any other comment about the code? |
|
Yes, I made a comment above:
|
|
oh sorry, didn't see that. Yes, you are right there, I'll try to improve that. |
|
I'm also wondering if it would be better to split the modes into separate widgets:
All 3 widget classes could inherit from a base class. |
|
Yes, that could work. I was trying to add something like that with jquery, but I'm having issues trying to get values. Can't find the issue. |
There was a problem hiding this comment.
This shouldn't be part of the PR.
There was a problem hiding this comment.
Yes, I just uploaded this changes so you can check the code. But don't pay attention to that.
2 participants
The operator was added to the widget, now you can choose between add/in
http://wordpress.org/support/topic/list-view-does-not-update-correctly