Skip to content

feat: Modernize codebase with Python 3.10+ support and comprehensive improvements #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
script3r merged 13 commits into from
Sep 13, 2025
Merged

feat: Modernize codebase with Python 3.10+ support and comprehensive improvements #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4fd187
Fix CI issues
script3r Sep 13, 2025
b1363ce
fix: Fix Django version installation in CI workflow
script3r Sep 13, 2025
41bc4a2
refactor: Simplify CI matrix to essential Python/Django combinations
script3r Sep 13, 2025
fe49842
fix: Install package in development mode for CI tests
script3r Sep 13, 2025
a3f601f
fix: Resolve flake8 linting issues
script3r Sep 13, 2025
54a972b
fix: Break long lines to meet flake8 line length requirements
script3r Sep 13, 2025
af09502
fix: Resolve all mypy type checking errors
script3r Sep 13, 2025
3681f09
style: Update line length to 120 characters
script3r Sep 13, 2025
e8c1277
fix: Add mypy configuration to ignore tink import errors
script3r Sep 13, 2025
c86af7b
refactor: Remove mypy from CI and codebase
script3r Sep 13, 2025
d66a88d
feat: Add Pyright type checking instead of mypy
script3r Sep 13, 2025
1f5e23e
fix: Remove unused imports to fix flake8 errors
script3r Sep 13, 2025
1a86f76
fix: Update requirements-dev.txt to include pyright
script3r Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions .github/workflows/django-tink-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
django-version: ["5.2", "5.1", "5.0"]
exclude:
include:
- python-version: "3.10"
django-version: "5.0"
- python-version: "3.11"
django-version: "5.0"
- python-version: "3.12"
django-version: "5.0"
- python-version: "3.13"
django-version: "5.0"
- python-version: "3.14"
django-version: "5.0"
django-version: "5.2"
- python-version: "3.13.7"
django-version: "5.2"
- python-version: "3.13.7"
django-version: "5.1"
Copy link

@cursor cursor bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CI Mismatch: Python and Django Versions

The pyproject.toml declares support for Python 3.11 and 3.12, but these versions are no longer tested in CI (GitHub Actions and Tox), risking undetected compatibility issues. Additionally, the CI workflow tests Django 5.1, even though pyproject.toml requires Django>=5.2.6, which means CI is running against an unsupported Django version and could give misleading results.

Additional Locations (2)

Fix in Cursor Fix in Web


steps:
- name: Checkout code
Expand All @@ -46,11 +40,21 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r requirements-test.txt
pip install "Django>=${{ matrix.django-version }},<$(python -c 'import sys; print(".".join(map(str, sys.version_info[:2])))').0"
# Install specific Django version based on matrix
case "${{ matrix.django-version }}" in
"5.1")
pip install "Django>=5.1,<5.2"
;;
"5.2")
pip install "Django>=5.2,<5.3"
;;
esac
# Install the package in development mode
pip install -e .

- name: Run tests
run: |
pytest tink_fields/test/ -v --cov=tink_fields --cov-report=xml --cov-report=term-missing
pytest -v --cov=tink_fields --cov-report=xml --cov-report=term-missing

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
Expand All @@ -66,15 +70,16 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python 3.14
- name: Set up Python 3.13.7
uses: actions/setup-python@v5
with:
python-version: "3.14"
python-version: "3.13.7"

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements-dev.txt
pip install pyright

- name: Run Black
run: black --check tink_fields/
Expand All @@ -83,21 +88,22 @@ jobs:
run: isort --check-only tink_fields/

- name: Run flake8
run: flake8 tink_fields/
run: flake8 tink_fields/ --max-line-length=120

- name: Run Pyright
run: pyright

- name: Run mypy
run: mypy tink_fields/

security:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python 3.14
- name: Set up Python 3.13.7
uses: actions/setup-python@v5
with:
python-version: "3.14"
python-version: "3.13.7"

- name: Install dependencies
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python 3.14
- name: Set up Python 3.13.7
uses: actions/setup-python@v5
with:
python-version: "3.14"
python-version: "3.13.7"

- name: Cache pip dependencies
uses: actions/cache@v4
Expand Down Expand Up @@ -74,10 +74,10 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python 3.14
- name: Set up Python 3.13.7
uses: actions/setup-python@v5
with:
python-version: "3.14"
python-version: "3.13.7"

- name: Install released package
run: |
Expand Down
160 changes: 160 additions & 0 deletions .pyre/pyre.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
2025-09-13 14:16:09,623 [PID 83382] INFO Could not determine the number of Pyre workers from configuration. Auto-set the value to 4.
2025-09-13 14:16:09,624 [PID 83382] INFO Writing arguments into /var/folders/s8/lcrfctmn5tb2th2fxmt8cdpr0000gn/T/pyre_arguments_g2x2809m.json...
2025-09-13 14:16:09,625 [PID 83382] DEBUG Arguments:
{
"source_paths": {
"kind": "simple",
"paths": [
"/Users/script3r/Projects/django-tink-fields/tink_fields"
]
},
"search_paths": [
"/Users/script3r/Projects/django-tink-fields/.venv/lib/python3.13/site-packages"
],
"excludes": [
"tink_fields/test"
],
"checked_directory_allowlist": [
"/Users/script3r/Projects/django-tink-fields/tink_fields"
],
"checked_directory_blocklist": [],
"extensions": [],
"log_path": "/Users/script3r/Projects/django-tink-fields/.pyre",
"global_root": "/Users/script3r/Projects/django-tink-fields",
"debug": false,
"python_version": {
"major": 3,
"minor": 9,
"micro": 23
},
"shared_memory": {},
"parallel": true,
"number_of_workers": 4,
"additional_logging_sections": [],
"show_error_traces": false,
"strict": true
}
2025-09-13 14:16:11,767 [PID 83382] DEBUG
2025-09-13 14:16:11,768 [PID 83382] DEBUG Usage: pyre [OPTIONS] COMMAND [ARGS]...
2025-09-13 14:16:11,768 [PID 83382] DEBUG Try 'pyre -h' for help.
2025-09-13 14:16:11,769 [PID 83382] DEBUG
2025-09-13 14:16:11,769 [PID 83382] DEBUG Error: No such command 'newcheck'.
2025-09-13 14:16:11,821 [PID 83382] ERROR Check command exited with non-zero return code: 12.
2025-09-13 14:16:19,816 [PID 83534] INFO No binary specified, looking for `pyre.bin` in PATH
2025-09-13 14:16:19,816 [PID 83534] INFO Could not determine the number of Pyre workers from configuration. Auto-set the value to 4.
2025-09-13 14:16:19,816 [PID 83534] INFO No typeshed specified, looking for it...
2025-09-13 14:16:19,816 [PID 83534] DEBUG Could not find bundled typeshed. Try importing typeshed directly...
2025-09-13 14:16:19,816 [PID 83534] DEBUG `import typeshed` failed.
2025-09-13 14:16:19,816 [PID 83534] WARNING Could not find a suitable typeshed. Types for Python builtins and standard libraries may be missing!
2025-09-13 14:16:19,818 [PID 83534] INFO Writing arguments into /var/folders/s8/lcrfctmn5tb2th2fxmt8cdpr0000gn/T/pyre_arguments_ubmcn97i.json...
2025-09-13 14:16:19,818 [PID 83534] DEBUG Arguments:
{
"source_paths": {
"kind": "simple",
"paths": [
"/Users/script3r/Projects/django-tink-fields/tink_fields"
]
},
"search_paths": [],
"excludes": [
"tink_fields/test"
],
"checked_directory_allowlist": [
"/Users/script3r/Projects/django-tink-fields/tink_fields"
],
"checked_directory_blocklist": [],
"extensions": [],
"log_path": "/Users/script3r/Projects/django-tink-fields/.pyre",
"global_root": "/Users/script3r/Projects/django-tink-fields",
"debug": false,
"python_version": {
"major": 3,
"minor": 9,
"micro": 23
},
"shared_memory": {},
"parallel": true,
"number_of_workers": 4,
"additional_logging_sections": [],
"show_error_traces": false,
"strict": true
}
2025-09-13 14:16:23,493 [PID 83534] PERFORMANCE Initialized shared memory (heap size: 8589934592, dep table pow: 1, hash table pow: 26): 0.000s
2025-09-13 14:16:23,508 [PID 83534] PERFORMANCE Initialized multiprocessing workers (workers: 4): 0.014s
2025-09-13 14:16:23,509 [PID 83534] INFO Building module tracker...
2025-09-13 14:16:23,510 [PID 83534] PERFORMANCE Module tracker built: 0.001s
2025-09-13 14:16:23,510 [PID 83534] PERFORMANCE Full environment built: 0.001s
2025-09-13 14:16:23,510 [PID 83534] INFO Collecting all definitions...
2025-09-13 14:16:23,642 [PID 83534] PERFORMANCE Collected definitions (defines: 75): 0.131s
2025-09-13 14:16:23,642 [PID 83534] INFO Checking 75 functions...
2025-09-13 14:16:23,729 [PID 83534] INFO Processed 10 of 75 functions
2025-09-13 14:16:23,733 [PID 83534] INFO Processed 20 of 75 functions
2025-09-13 14:16:23,733 [PID 83534] INFO Processed 30 of 75 functions
2025-09-13 14:16:23,734 [PID 83534] INFO Processed 40 of 75 functions
2025-09-13 14:16:23,809 [PID 83534] INFO Processed 50 of 75 functions
2025-09-13 14:16:23,812 [PID 83534] INFO Processed 60 of 75 functions
2025-09-13 14:16:23,815 [PID 83534] INFO Processed 70 of 75 functions
2025-09-13 14:16:23,820 [PID 83534] INFO Processed 75 of 75 functions
2025-09-13 14:16:23,821 [PID 83534] PERFORMANCE Check_TypeCheck: 0.178s
2025-09-13 14:16:23,821 [PID 83534] MEMORY Shared memory size post-typecheck (size: 0)
2025-09-13 14:16:23,821 [PID 83534] INFO Postprocessing 9 sources...
2025-09-13 14:16:23,884 [PID 83534] INFO Postprocessed 3 of 9 sources
2025-09-13 14:16:23,887 [PID 83534] INFO Postprocessed 6 of 9 sources
2025-09-13 14:16:23,889 [PID 83534] INFO Postprocessed 9 of 9 sources
2025-09-13 14:16:23,889 [PID 83534] PERFORMANCE Check_Postprocessing: 0.068s
2025-09-13 14:16:23,889 [PID 83534] PERFORMANCE Check (request kind: FullCheck): 0.380s
2025-09-13 14:16:23,904 [PID 83534] ERROR Found 117 type errors!
2025-09-13 14:16:31,386 [PID 83717] INFO No binary specified, looking for `pyre.bin` in PATH
2025-09-13 14:16:31,386 [PID 83717] INFO Could not determine the number of Pyre workers from configuration. Auto-set the value to 4.
2025-09-13 14:16:31,386 [PID 83717] INFO No typeshed specified, looking for it...
2025-09-13 14:16:31,386 [PID 83717] DEBUG Could not find bundled typeshed. Try importing typeshed directly...
2025-09-13 14:16:31,386 [PID 83717] DEBUG `import typeshed` failed.
2025-09-13 14:16:31,386 [PID 83717] WARNING Could not find a suitable typeshed. Types for Python builtins and standard libraries may be missing!
2025-09-13 14:16:31,387 [PID 83717] INFO Writing arguments into /var/folders/s8/lcrfctmn5tb2th2fxmt8cdpr0000gn/T/pyre_arguments_685un5bl.json...
2025-09-13 14:16:31,387 [PID 83717] DEBUG Arguments:
{
"source_paths": {
"kind": "simple",
"paths": [
"/Users/script3r/Projects/django-tink-fields/tink_fields"
]
},
"search_paths": [],
"excludes": [
"tink_fields/test"
],
"checked_directory_allowlist": [
"/Users/script3r/Projects/django-tink-fields/tink_fields"
],
"checked_directory_blocklist": [],
"extensions": [],
"log_path": "/Users/script3r/Projects/django-tink-fields/.pyre",
"global_root": "/Users/script3r/Projects/django-tink-fields",
"debug": false,
"python_version": {
"major": 3,
"minor": 9,
"micro": 23
},
"shared_memory": {},
"parallel": true,
"number_of_workers": 4,
"additional_logging_sections": [
"-progress"
],
"show_error_traces": false,
"strict": false
}
2025-09-13 14:16:31,441 [PID 83717] PERFORMANCE Initialized shared memory (heap size: 8589934592, dep table pow: 1, hash table pow: 26): 0.000s
2025-09-13 14:16:31,455 [PID 83717] PERFORMANCE Initialized multiprocessing workers (workers: 4): 0.012s
2025-09-13 14:16:31,455 [PID 83717] INFO Building module tracker...
2025-09-13 14:16:31,456 [PID 83717] PERFORMANCE Module tracker built: 0.001s
2025-09-13 14:16:31,456 [PID 83717] PERFORMANCE Full environment built: 0.001s
2025-09-13 14:16:31,456 [PID 83717] INFO Collecting all definitions...
2025-09-13 14:16:31,585 [PID 83717] PERFORMANCE Collected definitions (defines: 75): 0.128s
2025-09-13 14:16:31,585 [PID 83717] INFO Checking 75 functions...
2025-09-13 14:16:31,747 [PID 83717] PERFORMANCE Check_TypeCheck: 0.162s
2025-09-13 14:16:31,747 [PID 83717] MEMORY Shared memory size post-typecheck (size: 0)
2025-09-13 14:16:31,814 [PID 83717] PERFORMANCE Check_Postprocessing: 0.066s
2025-09-13 14:16:31,814 [PID 83717] PERFORMANCE Check (request kind: FullCheck): 0.359s
2025-09-13 14:16:31,828 [PID 83717] ERROR Found 49 type errors!
Copy link

@cursor cursor bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Log File with Sensitive Data Committed

A Pyre type checker log file, containing local development paths, timestamps, process IDs, and debug information, was accidentally committed. This temporary development artifact should not be in the repository.

Fix in Cursor Fix in Web

Loading