Allow specifying a retry policy on elasticsearch communication #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces our own exceptions for the following error cases - Not being able to connect to ES when determining versions. - Not being able to parse version numbers. - Not utilizing a secure connection on attempting to login.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
One issue with the current setup is that any action to elastic is always retried endlessly. This is problematic with logging, which (IMO) shouldn't be the reason an application hangs.
The hanging occurs because the cleanup (called on exit of the scope of
withLoggerin the calling thread) of a bulk logger attempts to flush it's buffer to the log-medium, in this case elastic which may be unavailable, doing a step & sync. This fixes it by allowing to specify a retry policy a la retry, that's used when attempting the action.