refactor opcode circuit dispatching and vector allocation #1222
+703
−633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation of #1220 to support single circuit subscribe to multi riscv opcodes
Change summary
emulator emit steps -> single vector -> then dispatcher multi vectorto new flowemulator emit steps -> multi vector, save one redundant allocationassign_opcode!(ADD, AddInstruction<E>, add_config);->assign_opcode!(AddInstruction<E>, add_config);and dispatch deal with routing for usBenchmark
test with
23817600block, e2e remain no changeremain no change which is expected. Because 1st shard we still need to allocated vector, while shard > 0 pipeline gpu proving time is dominated
For detail breakdown
assign_opcode_circuitaround 10% improvement