Open
Conversation
Allow specification of guest heap and stack sizes on the command line in more convenient units than just raw bytes.
This avoids spam like the following going on for thousands of lines:
```
INFO e2e: Running on platform Ceno Platform { rom: 536870912..538373056, prog_data: {536870912, [...]
```
This cuts down on logging spam.
…hias/sproll-proof
matthiasgoergens
requested review from
icemelon,
lightsing,
lispc,
mcalancea and
naure
| self.public_io, | ||
| self.hints, | ||
| self.unsafe_ecall_nop | ||
| "Platform {{ rom: {:#x?}, prog_data: {prog_data}, stack: {:#x?}, heap: {:x?}, public_io: {:#x?}, hints: {:#x?}, unsafe_ecall_nop: {} }}", |
Contributor
Author
There was a problem hiding this comment.
Hex is easier to read here (because we use round numbers, only when expressed in powers of 2), and it's also how we specify these numbers in our linker script etc.
| pi: PublicValues<u32>, | ||
| } | ||
|
|
||
| // TODO(Matthias): handle hints properly. |
Contributor
Author
There was a problem hiding this comment.
This is something to fix soon. But I don't know enough at the moment.
It's definitely broken in master, though.
hero78119
reviewed
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #809 because we need the non-controversial parts for other benchmarks. That is anything but
pub const MAX_NUM_VARIABLES: usize = 27;