Fix: Crate type must to be "(rust)lib" to be imported by outher rust project

[noel2004]

We must also set the create-type to both "staticlib" and "lib" (cargo enable to build multiple lib types by one-fly now). "lib" enable other rust crate to depend on this crate.

Summary by CodeRabbit

• Chores
  • Updated ignore rules to exclude the target directory or file.
  • Changed build configuration to allow producing both static and Rust library crates.
  • Updated Rust toolchain management by removing component-specific toolchain files and introducing a unified toolchain version for the project.

[coderabbitai]

Walkthrough

The updates adjust Rust toolchain configuration and crate output settings. A new top-level rust-toolchain file pins the Rust version to nightly-2025-02-14, while per-crate toolchain files are removed. Both encoder crates now produce both static and Rust libraries. The .gitignore is updated to exclude the target directory.

Changes

Files/Paths	Change Summary
.gitignore	Added target directory to ignored files.
libzstd/encoder-legacy/Cargo.toml, libzstd/encoder-standard/Cargo.toml	Added "lib" crate type to build outputs alongside "staticlib".
libzstd/encoder-legacy/rust-toolchain, libzstd/encoder-standard/rust-toolchain	Removed per-crate Rust toolchain version pinning files.
rust-toolchain	Introduced new file specifying Rust nightly-2025-02-14 as the toolchain for the entire project.

Suggested reviewers

• colinlyguo

Poem

In the warren, code hops anew,
With toolchains fresh and crates in view.
Old pins removed, one path to steer,
The target burrow’s out of here!
Rusty carrots, static, lib—
A rabbit’s joy, oh what a fib!
🥕✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rust-toolchain (1)

1-2: Optional: switch to TOML-style toolchain manifest to add tools

The single-line form works, but using the TOML format lets you pin extra components (e.g. clippy, rustfmt) and future-proofs the file:

-nightly-2025-02-14
+[toolchain]
+channel = "nightly-2025-02-14"
+components = ["clippy", "rustfmt"]

No action required if you don’t need the extras.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef596df and cf65413.

📒 Files selected for processing (6)

• .gitignore (1 hunks)
• libzstd/encoder-legacy/Cargo.toml (1 hunks)
• libzstd/encoder-legacy/rust-toolchain (0 hunks)
• libzstd/encoder-standard/Cargo.toml (1 hunks)
• libzstd/encoder-standard/rust-toolchain (0 hunks)
• rust-toolchain (1 hunks)

💤 Files with no reviewable changes (2)

• libzstd/encoder-legacy/rust-toolchain
• libzstd/encoder-standard/rust-toolchain

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: check
• GitHub Check: tests

🔇 Additional comments (3)

.gitignore (1)

41-42: target now ignored – sensible default for Rust projects

Ignoring the Rust target directory keeps build artifacts out of VCS and reduces repo bloat.

libzstd/encoder-legacy/Cargo.toml (1)

8-10: lib crate type added – unblocks downstream Rust dependencies

Previously the crate exported only a staticlib, preventing it from being used as a normal Rust dependency. Adding "lib" alongside "staticlib" fixes this without breaking the static use-case.

libzstd/encoder-standard/Cargo.toml (1)

8-10: Mirrors legacy encoder change – now builds both staticlib and lib

Consistent with the legacy crate and necessary for Rust consumers. Looks good.