Skip to content

fix: Consider all transactions in chunk hash #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thegaram merged 4 commits into from
Aug 26, 2025
Merged

fix: Consider all transactions in chunk hash #62

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01efe0d
fix: Consider all transactions in chunk hash
Thegaram Aug 22, 2025
4eac6d1
Merge branch 'main' into Thegaram-patch-1
Thegaram Aug 25, 2025
09129b6
adjust
Thegaram Aug 25, 2025
9e1dd6c
nit
Thegaram Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions encoding/codecv7_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,10 +460,6 @@ func (c *daChunkV7) Hash() (common.Hash, error) {
// concatenate l1 tx hashes
for _, blockTxs := range c.transactions {
for _, txData := range blockTxs {
if txData.Type != types.L1MessageTxType {
continue
}

hashBytes := common.FromHex(txData.TxHash)
if len(hashBytes) != common.HashLength {
return common.Hash{}, fmt.Errorf("unexpected hash: %s", txData.TxHash)
Expand Down