wip4

Author: kunxian-xia

extensions/native/circuit/src/poseidon2/chip.rs

@@ -23,12 +23,16 @@ use openvm_stark_backend::{
     p3_maybe_rayon::prelude::{IntoParallelIterator, ParallelSliceMut, *},
 };
 
-use crate::poseidon2::{
-    columns::{
-        InsideRowSpecificCols, MultiObserveCols, NativePoseidon2Cols, SimplePoseidonSpecificCols,
-        TopLevelSpecificCols,
+use crate::{
+    mem_fill_helper,
+    poseidon2::{
+        columns::{
+            InsideRowSpecificCols, MultiObserveCols, NativePoseidon2Cols,
+            SimplePoseidonSpecificCols, TopLevelSpecificCols,
+        },
+        CHUNK,
     },
-    CHUNK,
+    tracing_read_native_helper,
 };
 
 #[derive(Clone)]
@@ -1240,24 +1244,3 @@ impl<F: PrimeField32, const SBOX_REGISTERS: usize> NativePoseidon2Filler<F, SBOX
         &inner.ending_full_rounds.last().unwrap().post
     }
 }
-
-fn tracing_read_native_helper<F: PrimeField32, const BLOCK_SIZE: usize>(
-    memory: &mut TracingMemory,
-    ptr: u32,
-    base_aux: &mut MemoryBaseAuxCols<F>,
-) -> [F; BLOCK_SIZE] {
-    let mut prev_ts = 0;
-    let ret = tracing_read_native(memory, ptr, &mut prev_ts);
-    base_aux.set_prev(F::from_canonical_u32(prev_ts));
-    ret
-}
-
-/// Fill `MemoryBaseAuxCols`, assuming that the `prev_timestamp` is already set in `base_aux`.
-fn mem_fill_helper<F: PrimeField32>(
-    mem_helper: &MemoryAuxColsFactory<F>,
-    timestamp: u32,
-    base_aux: &mut MemoryBaseAuxCols<F>,
-) {
-    let prev_ts = base_aux.prev_timestamp.as_canonical_u32();
-    mem_helper.fill(prev_ts, timestamp, base_aux);
-}