Skip to content

Conversation

@yiweichi
Copy link
Member

This PR updates gas_limit field of ScrollBuilderConfig to a Option to make it consistent with max_da_block_size field.

Corresponding issue: #292

@yiweichi yiweichi changed the title feat: update gas_limit field of ScrollBuilderConfig to a Option<u64> feat: update gas_limit field of ScrollBuilderConfig to a Option<u64> Jul 31, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 31, 2025

CodSpeed Performance Report

Merging #300 will not alter performance

Comparing feat-update-gas-limit-to-option (42af0b0) with scroll (f451fe8)

Summary

✅ 77 untouched benchmarks

@yiweichi yiweichi requested review from frisitano and greged93 August 4, 2025 13:16
Copy link

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@greged93 greged93 merged commit eb020e1 into scroll Aug 6, 2025
45 checks passed
@greged93 greged93 deleted the feat-update-gas-limit-to-option branch August 6, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants