Skip to content

Conversation

@greged93
Copy link

@greged93 greged93 commented Aug 6, 2025

Loads the withdraw root into the execution witness. Resolves #278.

@greged93 greged93 requested a review from frisitano August 6, 2025 09:21
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 6, 2025

CodSpeed Performance Report

Merging #312 will not alter performance

Comparing feat/withdraw-trie-root-slot (f53257c) with scroll (f451fe8)

Summary

✅ 77 untouched benchmarks

Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 requested a review from Thegaram August 6, 2025 10:09
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93 greged93 merged commit 5a7d446 into scroll Aug 8, 2025
44 checks passed
@greged93 greged93 deleted the feat/withdraw-trie-root-slot branch August 8, 2025 10:05
greged93 added a commit that referenced this pull request Aug 8, 2025
* feat: update execute_with_state_closure closure

Signed-off-by: Gregory Edison <[email protected]>

* feat: LoadWithdrawRoot

Signed-off-by: Gregory Edison <[email protected]>

* chore: fix clippy docs (paradigmxyz#17726)

Co-authored-by: Alexey Shekhirin <[email protected]>

* fix: clippy

Signed-off-by: Gregory Edison <[email protected]>

---------

Signed-off-by: Gregory Edison <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
frisitano added a commit that referenced this pull request Aug 18, 2025
* feat: block validation

Signed-off-by: Gregory Edison <[email protected]>

* feat: header validation

Signed-off-by: Gregory Edison <[email protected]>

* feat: body validation

Signed-off-by: Gregory Edison <[email protected]>

* feat: withdraw trie root slot (#312)

* feat: update execute_with_state_closure closure

Signed-off-by: Gregory Edison <[email protected]>

* feat: LoadWithdrawRoot

Signed-off-by: Gregory Edison <[email protected]>

* chore: fix clippy docs (paradigmxyz#17726)

Co-authored-by: Alexey Shekhirin <[email protected]>

* fix: clippy

Signed-off-by: Gregory Edison <[email protected]>

---------

Signed-off-by: Gregory Edison <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>

* chore: reorg

Signed-off-by: Gregory Edison <[email protected]>

* feat: answer comment + add unit test

Signed-off-by: Gregory Edison <[email protected]>

* feat: answer comment

Signed-off-by: Gregory Edison <[email protected]>

* feat: check sequential L1 message post EuclidV2

Signed-off-by: Gregory Edison <[email protected]>

---------

Signed-off-by: Gregory Edison <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: frisitano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load L2MessageQueueAddress::WithdrawTrieRootSlot in witness

4 participants