feat: update scroll consensus #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
* feat: update execute_with_state_closure closure Signed-off-by: Gregory Edison <[email protected]> * feat: LoadWithdrawRoot Signed-off-by: Gregory Edison <[email protected]> * chore: fix clippy docs (paradigmxyz#17726) Co-authored-by: Alexey Shekhirin <[email protected]> * fix: clippy Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]>
CodSpeed Performance ReportMerging #314 will not alter performanceComparing Summary
|
Signed-off-by: Gregory Edison <[email protected]>
frisitano
previously approved these changes
Aug 8, 2025
Collaborator
|
Rust logic looks sound, deferring to the subject matter experts for consnsus logic review. |
frisitano
reviewed
Aug 11, 2025
Signed-off-by: Gregory Edison <[email protected]>
colinlyguo
previously approved these changes
Aug 11, 2025
Signed-off-by: Gregory Edison <[email protected]>
yiweichi
reviewed
Aug 11, 2025
Signed-off-by: Gregory Edison <[email protected]>
frisitano
previously approved these changes
Aug 18, 2025
frisitano
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the scroll consensus checks based on the l2geth clique and system config consensus. Successfully synced to block 18663346 on Mainnet with the consensus updates.
Resolves #290.
Resolves #296.
Note: Clique consensus signer verification isn't performed. I don't see any issues with skipping it, but do tell me if I'm wrong. This check would require some work to save signer snapshots.