Feat/add chain spec hardfork #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thegaram
reviewed
Dec 3, 2024
Co-authored-by: Péter Garamvölgyi <[email protected]>
frisitano
reviewed
Dec 4, 2024
…/reth into feat/add_chain_spec_hardfork
…ain_spec_hardfork
greged93
reviewed
Dec 4, 2024
greged93
left a comment
greged93
left a comment
There was a problem hiding this comment.
I think we should not have the EIP150, EIP155 and EIP158 in the Scroll hardforks, these should be Tangerine and SpuriousDragon
georgehao
changed the title
frisitano
reviewed
Dec 6, 2024
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Added a few comments inline, mostly around naming and documentation.
greged93
reviewed
Dec 6, 2024
greged93
reviewed
Dec 6, 2024
greged93
left a comment
greged93
left a comment
There was a problem hiding this comment.
just a couple of small comments on the ScrollChainSpecBuilder
frisitano
reviewed
Dec 9, 2024
frisitano
reviewed
Dec 9, 2024
frisitano
reviewed
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.