feat: ci #18
Merged
feat: ci #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
commented
Jan 31, 2025
| @@ -0,0 +1,6 @@ | |||
| version: 2 | |||
Contributor
Author
There was a problem hiding this comment.
Latest recommendation for the Rust ecosystem is to add the Cargo.lock file to the version control, and either use dependabot or cargo update && cargo test in CI.
rust-lang/cargo#8728
frisitano
reviewed
Jan 31, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good! One proposal - should we include a Makefile that allows us to run the lints locally? This will allow us to assert compliance with CI before pushing and could speed up dev cycles.
.github/workflows/test.yaml
Outdated
| - name: Run unit tests | ||
| run: cargo nextest run --workspace --locked -E '!kind(test)' | ||
|
|
||
| it: |
Collaborator
There was a problem hiding this comment.
maybe it would be preferable to be more verbose and name this integration.
Contributor
Author
|
Agree, on it! |
frisitano
approved these changes
Feb 3, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks great, thanks for this! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3