feat: improve Docker e2e test framework and implement sequencer switching in the test#315
Merged
jonastheis merged 36 commits intomainfrom Sep 22, 2025
Merged
feat: improve Docker e2e test framework and implement sequencer switching in the test#315jonastheis merged 36 commits intomainfrom
jonastheis merged 36 commits intomainfrom
Conversation
…gner' into feat/claude.md
…e 500ms for both sequencers
…to connect to each other via RPC
This reverts commit 8bbc5e2.
…gner' into feat/improve-docker-e2e-test
…rom database in header transform
There was a problem hiding this comment.
Pull Request Overview
This PR implements significant improvements to the Docker e2e test framework and introduces a comprehensive heterogeneous client synchronization test. The changes enhance the testing infrastructure's reliability and add validation for complex network scenarios involving multiple client implementations.
Key changes:
- Replaced a simple block propagation test with an extensive sequencer handoff test that validates cross-client synchronization
- Enhanced Docker testing framework with better timeout handling, container management, and peer networking utilities
- Consolidated workspace dependency management by centralizing reth dependencies in the root Cargo.toml
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/tests/heterogeneous_client_sync_and_sequencer_handoff.rs | New comprehensive test validating cross-client block propagation and sequencer transitions |
| tests/tests/block_propagation_multi_clients.rs | Removed simple test replaced by the more comprehensive heterogeneous test |
| tests/src/utils.rs | Added peer management functions and improved timeout handling for better test reliability |
| tests/src/lib.rs | Simplified exports to use glob imports for better ergonomics |
| tests/src/docker_compose.rs | Enhanced container management with IP resolution, enode URL construction, and log dumping |
| tests/launch_*.bash | Updated node configuration scripts to enable admin APIs and improve networking |
| tests/l2geth-genesis-e2e.json | Added blocks_per_second configuration for system contract |
| Cargo.toml files | Consolidated reth dependencies to use workspace-level definitions |
| Dockerfile.test | Added sccache for faster builds and improved cache mounting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
frisitano
reviewed
Sep 19, 2025
Collaborator
frisitano
left a comment
There was a problem hiding this comment.
Looks good. Left a few commens inline.
frisitano
previously approved these changes
Sep 19, 2025
frisitano
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274