Merged
Conversation
* init bridge implementation * extend bridge implementation * refactor and clean up dependencies * add .vscode to .gitignore * lint * spacing * cleanup * wrap inner block import in bridge * add bridge integration test * refactor and clean up * add comments * migrate shared dependencies to workspace * feature propogation * lints and feature fix * remove scroll feature * add scroll feature * integrate reth upstream changes * address PR feedback * stash * add systemd service file * update systemd file * update systemd file * address comments * rollup node manager * merge main * add Cargo.lock * lint * lint * lint * lint * ci remove no-dev-deps * fix serde dep - scroll-wire * skip no_std on scroll-engine and scroll-rollup-node * skip no_std on scroll-engine and scroll-rollup-node * address comments * lints * cleanup * tsets * lint + refactor * refactor engine api call ordering * lint * fix fcu * lint * remove syncing error return on new payload * update forkchoice state after succesfully new payload * update reth following chainspec fork id logic change * PR feedback * lints * lints
greged93
commented
Mar 12, 2025
greged93
commented
Mar 12, 2025
| address!("0x0d7E906BD9cAFa154b048cFa766Cc1E54E39AF9B"); | ||
|
|
||
| /// The [`Filter`] used by the [`crate::L1Watcher`] to index events relevant to the rollup node. | ||
| pub static L1_WATCHER_LOG_FILTER: LazyLock<Filter> = LazyLock::new(|| { |
Contributor
Author
There was a problem hiding this comment.
if we add the hook solution in the L1 watcher, this can go
greged93
commented
Mar 12, 2025
|
|
||
| /// The L1 notification type yielded by the [`L1Watcher`]. | ||
| #[derive(Debug, PartialEq, Eq)] | ||
| pub enum L1Notification { |
Contributor
Author
There was a problem hiding this comment.
This needs to evolve based on the primitives PR discussion
frisitano
reviewed
Mar 12, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Excellent job on this! I've left a few comments inline. Let me know what you think.
frisitano
reviewed
Mar 15, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Added a few more comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the L1 watcher in the rollup node.
Resolves #4