Conversation
greged93
force-pushed
the
fix/l1-messages-cursor
branch
from
031e889 to
4255f75
Compare
frisitano
previously approved these changes
Sep 18, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good, left some optional commnets inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the L1 messages cursor used in the sequencer by updating it on new payload events (blocks sequenced by the sequencer) and on block import events (blocks received from the network). Fixes #285.
Also updates the interface used for the L1 message provider, now exposing two methods
take_n_messages_from_indexandtake_n_messages_from_hash. An approach returning aStreamusing theget_l1_messagesoperation from theDatabaseReadOperationswould have been preferred, but was not possible for the reasons laid out in the doc comments.In summary, we can't implement
L1MessageProvideron aDatabaseTransactionProvider, because the stream captures the reference to theTx. We could have implementL1MessageProvider, but this seems to go against the current pattern of only accessing the database using theTxandTxMutstructures. Fixes #162.