Initial Database Implementation #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init bridge implementation * extend bridge implementation * refactor and clean up dependencies * add .vscode to .gitignore * lint * spacing * cleanup * wrap inner block import in bridge * add bridge integration test * refactor and clean up * add comments * migrate shared dependencies to workspace * feature propogation * lints and feature fix * remove scroll feature * add scroll feature * integrate reth upstream changes * address PR feedback * stash * add systemd service file * update systemd file * update systemd file * address comments * rollup node manager * merge main * add Cargo.lock * lint * lint * lint * lint * ci remove no-dev-deps * fix serde dep - scroll-wire * skip no_std on scroll-engine and scroll-rollup-node * skip no_std on scroll-engine and scroll-rollup-node * address comments * lints * cleanup * tsets * lint + refactor * refactor engine api call ordering * lint * fix fcu * lint * remove syncing error return on new payload * update forkchoice state after succesfully new payload * update reth following chainspec fork id logic change * PR feedback * lints * lints
greged93
reviewed
Mar 18, 2025
Contributor
greged93
left a comment
greged93
left a comment
There was a problem hiding this comment.
just a couple of questions, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a
Databaseimplementation responsible for reading and writing information to the database. We leverageseaORMwhich is an async rust based ORM. It has support formysql,postgresandsqlite. I would propose that we use an on disksqlitedatabase in the first instance.Implementation
We have 4 primary rust objects of interest, these are
Database,DatabaseTransaction,DatabaseOperationsandDatabaseConnectionProvider. TheDatabaseandDatabaseTransactionimplement theDatabaseConnectionProvidertrait which allows for a connection to the database to be sourced. We then have a blanket implementation ofDatabaseOperations, which defines various CRUD and streaming operations, for all types which implementDatabaseConnectionProvider.Migrations
We also introduce a
scroll-migrationcrate which is responsible for managing the rollup node migration.Considerations
Moving towards to we should standardize the naming of our crates. We have both
scroll-*androllup-node-*. We should consider if the two crates introduced in this PR should bescroll-*orrollup-node-*, I'm leaning towards the latter.