-
Notifications
You must be signed in to change notification settings - Fork 6
feat: update retry mechanism #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #358 will improve performances by 34.14%Comparing Summary
Benchmarks breakdown
|
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Added some minor comments inline, primiarly about when we should use the raw methods and when to instantiate a transaction.
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@frisitano should we merge this with the old benchmark and fix in another PR? |
Yes lets revent back to the old bencmarks, get CI green and merge. We can look at codespeed in another PR as you suggest. |
|
@frisitano regression seems to have came from not having a |
Can you elaborate on this please? In main we don't have a Also looks like CI isn't passing edit: Is this because in the derivation pipeline using the new api we would create a new transaction for each block data hint we fetched? |
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. lgtm
Yes, it seems like this slows the derivation process. |
c6cbd77 to
1b7b64f
Compare
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes: #319