Merged
Conversation
frisitano
approved these changes
Mar 21, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
This looks great!
I agree with your suggestion of returning a BatchInput instead of a CommitPayload, however, I suggest we do that in a follow up PR. We can consider replacing chunks with a CommitPayload. When implementing that change we should be mindful of the data model. It would be useful if you could add columns to the database model for the BatchInput such as num_l1_messages, l1_message_queue_start_index so that we can easily map between batches and l1 messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the decoding for the Scroll codec, from version 0 to 7.
Resolves #25