Merged
Conversation
greged93
commented
Mar 27, 2025
Comment on lines
35
to
37
| block_timestamp: ActiveValue::Set( | ||
| batch_input.block_timestamp.try_into().expect("block number should fit in i64"), | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
timestamp of the L1 block is required in order to fetch the blobs for the block.
greged93
force-pushed
the
feat/integrate-batch-changes
branch
from
32549df to
eeb7a63
Compare
frisitano
approved these changes
Apr 2, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good, left some minor comments inline.
| batch_commit.block_number.try_into().expect("block number should fit in i64"), | ||
| ), | ||
| block_timestamp: ActiveValue::Set( | ||
| batch_commit.block_timestamp.try_into().expect("block number should fit in i64"), |
Collaborator
There was a problem hiding this comment.
Suggested change
| batch_commit.block_timestamp.try_into().expect("block number should fit in i64"), | |
| batch_commit.block_timestamp.try_into().expect("block timestamp should fit in i64"), |
crates/providers/src/l1/mod.rs
Outdated
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl<P: L1MessageProvider + Sync> L1BlobProvider for OnlineL1Provider<P> { |
Collaborator
There was a problem hiding this comment.
Do we need the L1MessageProvider trait bound on P for this impl?
| .await | ||
| .map_err(Into::into)? | ||
| .ok_or(DerivationPipelineError::MissingL1Message)?; | ||
| let mut bytes = Vec::new(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| let mut bytes = Vec::new(); | |
| let mut bytes = Vec::with_capacity(l1_message.eip2718_encoded_length()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the providers crate, centralizing the provider traits and their implementations on the crate. Also provides the
OnlineL1Providerand theDatabaseL1MessagesProviderimplementations.