-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Sequencer #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Sequencer #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
reviewed
Apr 10, 2025
greged93
approved these changes
Apr 14, 2025
Contributor
greged93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Feel free to merge, just noted that you pointed to the scroll branch which isn't really needed but just a nit.
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the
Sequencercomponent, which is responsible for producing blocks. We have also made some modifications to theL1MessageProvidertrait such that now the base methods will yieldL1MessageWithBlockNumberinstead ofTxL1Message, this is beneficial as it allows us to implement theDatabaseL1MessageDelayProviderwhich can be used to wait for a number of L1 block confirmations before including the tx in a block. We get the existing functionality for free. I have not yet introducedDatabaseL1MessageDelayProviderinto the sequencer and will do so in a follow up PR.