Skip to content

Conversation

@lightsing
Copy link
Member

No description provided.

@lightsing lightsing requested a review from Copilot November 28, 2025 04:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces significant refactoring with breaking API changes, including:

  • Migration from rlp to alloy-rlp for RLP encoding/decoding
  • Introduction of lifetime parameters and Cow types for zero-copy optimizations
  • Refactored error handling with a new Response enum and RpcError type
  • Simplified version handling by moving version initialization to build-time
  • Reorganized configuration with suppress_empty_task_error moved from ProverConfig to CoordinatorConfig

Key Changes

  • Enhanced type safety with derive macros (EnumIs, FromRepr, Display) replacing manual implementations
  • Improved token management using OnceCell and Arc for concurrent access
  • Consolidated API request handling into a single generic request method

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils.rs Replaced runtime version initialization with compile-time constant using env! macros
src/prover/types.rs Migrated to derive macros and alloy-rlp for enum serialization
src/prover/mod.rs Removed test module, refactored task retrieval logic, updated to use Cow types
src/prover/builder.rs Updated to pass suppress_empty_task_error to coordinator client
src/coordinator_handler/types.rs Complete refactor of response handling and type definitions with zero-copy optimizations
src/coordinator_handler/key_signer.rs Minor import reordering
src/coordinator_handler/error.rs Renamed error variants and added EnumIs derive
src/coordinator_handler/coordinator_client.rs Refactored token management and error handling
src/coordinator_handler/api.rs Consolidated request methods into generic request function
src/config.rs Moved suppress_empty_task_error field to CoordinatorConfig
rust-toolchain.toml Updated nightly channel version
examples/local.rs Import reordering
examples/cloud.rs Import reordering
build.rs New file for build-time environment variable setup
Cargo.toml Updated version, edition, and dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants