Skip to content

Fix ci login #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbaizet-ledger merged 11 commits into from
Nov 21, 2024
Merged

Fix ci login #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
46295ff
fix ci-login by adding permissions to workflow
sbaizet-ledger Nov 21, 2024
45cdb72
Add registry permissions
sbaizet-ledger Nov 21, 2024
803b8b7
test
sbaizet-ledger Nov 21, 2024
e19d7b2
fix helm registry login
sbaizet-ledger Nov 21, 2024
2cb89ab
fix the remaining issues
sbaizet-ledger Nov 21, 2024
8f5cda6
test without the env variable HELM_GITHUB_PASSWORD
sbaizet-ledger Nov 21, 2024
4006311
remove the HELM_GITHUB_PASSWORD everywhere
sbaizet-ledger Nov 21, 2024
9aec250
test
sbaizet-ledger Nov 21, 2024
9fb7bf3
remove permissions on workflow
sbaizet-ledger Nov 21, 2024
af18c08
test
sbaizet-ledger Nov 21, 2024
2a0410c
revert scroll-sdk bump version
sbaizet-ledger Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/lint-test-charts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

- name: Run chart-testing (list-changed)
id: list-changed
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/publish-chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

# List chart change except scroll-sdk
- name: Run chart-testing (list-changed)
Expand Down Expand Up @@ -73,8 +71,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

# We filter here the scroll-sdk chart
- name: Push chart to ghcr
Expand Down Expand Up @@ -134,8 +130,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

# List scroll-sdk chart if it has changed
- name: Run chart-testing (list-changed)
Expand Down Expand Up @@ -174,8 +168,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

- name: Push chart to ghcr
if: steps.filter.outputs.addedOrModified == 'true'
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/publish-dev-chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

# List chart change except scroll-sdk
- name: Run chart-testing (list-changed)
Expand Down Expand Up @@ -74,9 +72,7 @@ jobs:

- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.HELM_GITHUB_PASSWORD }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}

# We filter here the scroll-sdk chart
- name: Push chart to ghcr
Expand Down Expand Up @@ -136,8 +132,6 @@ jobs:
- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"

# List scroll-sdk chart if it has changed
- name: Run chart-testing (list-changed)
Expand Down Expand Up @@ -175,9 +169,7 @@ jobs:

- name: Helm registry login
run: |
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.HELM_GITHUB_PASSWORD }}
env:
HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}

- name: Replace helm registry by helm/dev
run: |
Expand Down
Loading