clean up

Author: Thegaram

common/testcontainers/testcontainers.go

@@ -173,11 +173,7 @@ func (t *TestcontainerApps) GetPoSL1Client() (*rpc.Client, error) {
 	if err != nil {
 		return nil, err
 	}
-	rawClient, err := rpc.Dial(endpoint)
-	if err != nil {
-		return nil, fmt.Errorf("failed to dial L1 rpc endpoint, endpoint: %s, err: %w", endpoint, err)
-	}
-	return rawClient, nil
+	return rpc.Dial(endpoint)
 }
 
 // GetDBEndPoint returns the endpoint of the running postgres container

rollup/internal/controller/relayer/l1_relayer_metrics.go

@@ -46,7 +46,7 @@ func initL1RelayerMetrics(reg prometheus.Registerer) *l1RelayerMetrics {
 			}),
 			rollupL1RelayerGasPriceOracleFeeOverLimitTotal: promauto.With(reg).NewCounter(prometheus.CounterOpts{
 				Name: "rollup_layer1_gas_price_oracle_fee_over_limit_total",
-				Help: "The total number of layer1 gas price oracle fee over limit",
+				Help: "The total number of times when a gas price oracle fee update went over the configured limit",
 			}),
 		}
 	})

rollup/tests/bridge_test.go

@@ -94,8 +94,8 @@ func setupEnv(t *testing.T) {
 	rollupApp = bcmd.NewRollupApp(testApps, "../conf/config.json")
 
 	l1RawClient, err = testApps.GetPoSL1Client()
-	l1Client = ethclient.NewClient(l1RawClient)
 	assert.NoError(t, err)
+	l1Client = ethclient.NewClient(l1RawClient)
 	l2Client, err = testApps.GetL2GethClient()
 	assert.NoError(t, err)
 	l1GethChainID, err = l1Client.ChainID(context.Background())